HYPERFLEET-1058 - feat: Update e2e repo and remove dead code#122
HYPERFLEET-1058 - feat: Update e2e repo and remove dead code#122ma-hill wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (41)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
💤 Files with no reviewable changes (33)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR deprecates the local-kind-specific deployment infrastructure (deploy-scripts, .env.example, test adapters) and establishes a unified setup guide supporting both Kind and GCP. It introduces docs/setup.md as the primary environment configuration reference and env/env.local for defaulted variables. Makefile removes local kind targets and adds container image build targets (image, image-push, image-dev). Dockerfile stops copying deploy-scripts. Documentation across AGENTS.md, CONTRIBUTING.md, README.md, and guides is revised to reference the new setup flow, environment variables, and tier-based test execution patterns. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Security and Supply Chain NotesContainer Image Build Targets (CWE-427: Untrusted Search Path) Environment Variable Injection (CWE-94: Improper Control of Generation of Code) Removal of Deployment Automation (CWE-345: Insufficient Verification of Data Authenticity) Kubernetes API Credentials in Environment (CWE-798: Use of Hard-Coded Credentials) CI/CD Configuration Drift (CWE-426: Untrusted Search Path in an External Product) 🚥 Pre-merge checks | ✅ 9 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
Removes deploy scripts, Kind setup tooling, and adapter testdata that have been migrated to the infra repository. Adds environment files and cleanup scripts to support the new infra-based workflow. - Remove deploy-scripts/ directory (deploy-clm.sh, Kind scripts, adapter/API/common/helm/sentinel libraries) - Remove testdata/adapter-configs/ for all adapters (cl-deployment, cl-job, cl-maestro, cl-namespace, np-configmap) - Remove docs/local-kind-setup.md (replaced by infra repo setup) - Add env/env.ci and env/env.local for infra repo integration - Add scripts/cleanup-k8s-resources.sh and scripts/cleanup-pubsub-resources.sh - Add docs/setup.md with new setup instructions - Update docs/runbook.md, docs/getting-started.md, docs/development.md to reference infra repo - Update README.md, CONTRIBUTING.md, Dockerfile, and Makefile to remove old deployment targets
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@coderabbitai review |
✅ Action performedReview finished.
|
1 participant
Summary
Completes the migration from E2E-specific deployment scripts to using the centralized hyperfleet-infra repository for all HyperFleet component installations. This PR removes ~4500 lines of obsolete deployment code, adapter testdata, and Kind setup tooling that have been superseded by infra repo patterns. The E2E repo now focuses purely on test automation, relying on infra for environment setup and deployment.
HYPERFLEET-1058
Changes
deploy-scripts/directory containing:deploy-clm.sh(602 lines) — orchestration script replaced by infra repokind-local.shandkind-build-images.sh— Kind cluster management replaced by infra Makefile targetslib/adapter.sh,lib/api.sh,lib/common.sh,lib/helm.sh,lib/sentinel.sh,lib/gcp.sh).env.exampleand README documentationtestdata/adapter-configs/for all adapters (cl-deployment,cl-job,cl-maestro,cl-namespace,np-configmap) — adapter configs now live in infra repodocs/local-kind-setup.md— replaced by infra repo setup guideenv/env.ciandenv/env.localfor infra repo integration (environment variable configuration for CI and local development)scripts/cleanup-k8s-resources.shto uninstall Helm releases and delete namespaces (used in CI teardown)scripts/cleanup-pubsub-resources.shto remove GCP Pub/Sub topics and subscriptions (used in CI cleanup)docs/setup.mdconsolidating setup instructions for both local and CI environmentsdocs/runbook.mdto reference infra repo installation steps instead of deploy-clm.shdocs/getting-started.mdto point to new setup.md and infra repodocs/development.mdto remove references to old deployment workflowREADME.mdandCONTRIBUTING.mddirectory trees to reflect new structureDockerfileto copyenv/andscripts/directories instead ofdeploy-scripts/make local-up,make local-down,make local-rebuildtargets from MakefileAGENTS.mdsource of truth table to referencedocs/setup.mdinstead ofdocs/local-kind-setup.mdNotes
This PR is part of a broader effort to centralize HyperFleet deployment and infrastructure management in the infra repository (HYPERFLEET-1057). The E2E repo now assumes that component installation is handled externally via infra repo patterns.
The new workflow:
scripts/for teardownAll adapter configurations (values.yaml, adapter-config.yaml, task configs) have moved to the infra repository and are deployed via helmfile.
Test Plan
make test-allpassesmake lintpassesenv/andscripts/directories